KKcorps commented on code in PR #13298:
URL: https://github.com/apache/pinot/pull/13298#discussion_r1631045755
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/IngestionDelayTracker.java:
##########
@@ -174,6 +188,22 @@ private long getIngestionDelayMs(long ingestionTimeMs) {
return agedIngestionDelayMs;
}
+ private long getPartitionOffsetLag(IngestionOffsets offset) {
+ if (offset == null) {
+ return 0;
+ }
+ StreamPartitionMsgOffset msgOffset = offset._offset;
+ StreamPartitionMsgOffset latestOffset = offset._latestOffset;
+
+ // Compute aged delay for current partition
+ // TODO: Support other types of offsets
+ if (!(msgOffset instanceof LongMsgOffset && latestOffset instanceof
LongMsgOffset)) {
+ return 0;
Review Comment:
Other than this, Kinesis returns a BigInteger offset and Pulsar returns a
string offset that is composed of 3 longs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
