gortiz commented on code in PR #13303:
URL: https://github.com/apache/pinot/pull/13303#discussion_r1633023949


##########
pinot-common/src/test/java/org/apache/pinot/common/datablock/BaseDataBlockContract.java:
##########
@@ -1,42 +0,0 @@
-/**
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-package org.apache.pinot.common.datablock;
-
-import java.io.IOException;
-import java.nio.ByteBuffer;
-
-import static org.testng.Assert.*;
-
-
-public abstract class BaseDataBlockContract {
-
-  protected abstract BaseDataBlock deserialize(ByteBuffer byteBuffer, int 
versionType)
-      throws IOException;
-
-  public void testSerdeCorrectness(BaseDataBlock dataBlock)
-      throws IOException {
-    byte[] bytes = dataBlock.toBytes();
-    ByteBuffer byteBuffer = ByteBuffer.wrap(bytes);
-    int versionType = DataBlockUtils.readVersionType(byteBuffer);
-    BaseDataBlock deserialize = deserialize(byteBuffer, versionType);
-
-    assertEquals(byteBuffer.position(), bytes.length, "Buffer position should 
be at the end of the buffer");
-    assertEquals(deserialize, dataBlock, "Deserialized data block should be 
the same as the original data block");
-  }

Review Comment:
   Serde correctness is implemented now in the DataBlockSerde tests



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to