klsince commented on code in PR #13352:
URL: https://github.com/apache/pinot/pull/13352#discussion_r1634119955
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/readers/CompactedPinotSegmentRecordReader.java:
##########
@@ -36,19 +37,25 @@
public class CompactedPinotSegmentRecordReader implements RecordReader {
private final PinotSegmentRecordReader _pinotSegmentRecordReader;
private final RoaringBitmap _validDocIdsBitmap;
-
+ private final String _deleteRecordColumn;
+ // Reusable generic row to store the next row to return
+ private final GenericRow _nextRow = new GenericRow();
// Valid doc ids iterator
private PeekableIntIterator _validDocIdsIterator;
- // Reusable generic row to store the next row to return
- private GenericRow _nextRow = new GenericRow();
// Flag to mark whether we need to fetch another row
private boolean _nextRowReturned = true;
public CompactedPinotSegmentRecordReader(File indexDir, RoaringBitmap
validDocIds) {
+ this(indexDir, validDocIds, null);
+ }
+
+ public CompactedPinotSegmentRecordReader(File indexDir, RoaringBitmap
validDocIds,
+ @Nullable String deleteRecordColumn) {
Review Comment:
As it’s not safe to skip deleteRecord, so I would rather avoid it for less
confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
