soumitra-st commented on code in PR #13574:
URL: https://github.com/apache/pinot/pull/13574#discussion_r1676402235
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -292,7 +293,7 @@ private String getQueryResponse(String query, @Nullable
SqlNode sqlNode, String
// Validate data access
AccessControl accessControl = _accessControlFactory.create();
- if (!accessControl.hasDataAccess(httpHeaders, rawTableName)) {
+ if (!accessControl.hasAccess(rawTableName, AccessType.READ, httpHeaders,
Actions.Table.DOWNLOAD_SEGMENT)) {
Review Comment:
> All over our codebase (eg: PinotTableResstletResource), we pass the action
as endpointUrl. If we feel that a better identifier is needed to identify
endpointUrl, we can discuss.
@vvivekiyer , if we pass action as endpointUrl across the board, then I am
ok with that.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -292,7 +293,7 @@ private String getQueryResponse(String query, @Nullable
SqlNode sqlNode, String
// Validate data access
AccessControl accessControl = _accessControlFactory.create();
- if (!accessControl.hasDataAccess(httpHeaders, rawTableName)) {
+ if (!accessControl.hasAccess(rawTableName, AccessType.READ, httpHeaders,
Actions.Table.DOWNLOAD_SEGMENT)) {
Review Comment:
> All over our codebase (eg: PinotTableResstletResource), we pass the action
as endpointUrl. If we feel that a better identifier is needed to identify
endpointUrl, we can discuss.
@vvivekiyer , if we pass action as endpointUrl across the board, then I am
ok with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
