This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new abbe10c474 Remove preloading-type nature of enableSnapshot config
(#13579)
abbe10c474 is described below
commit abbe10c474cfa19dba02cdb14f61c69410f90a2f
Author: Pratik Tibrewal <[email protected]>
AuthorDate: Tue Jul 16 00:02:30 2024 +0530
Remove preloading-type nature of enableSnapshot config (#13579)
* Remove preloading-type nature of enableSnapshot config
* Remove snapshot when adding segment if snapshot is not enabled
---
.../upsert/BasePartitionUpsertMetadataManager.java | 23 +++-------------------
1 file changed, 3 insertions(+), 20 deletions(-)
diff --git
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
index d483a65c22..f03c9e8629 100644
---
a/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
+++
b/pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java
@@ -432,30 +432,13 @@ public abstract class BasePartitionUpsertMetadataManager
implements PartitionUps
String segmentName = segment.getSegmentName();
_logger.info("Adding segment: {}, current primary key count: {}",
segmentName, getNumPrimaryKeys());
long startTimeMs = System.currentTimeMillis();
-
- MutableRoaringBitmap validDocIds;
- if (_enableSnapshot) {
- validDocIds = segment.loadValidDocIdsFromSnapshot();
- if (validDocIds != null && validDocIds.isEmpty()) {
- _logger.info("Skip adding segment: {} without valid doc, current
primary key count: {}",
- segment.getSegmentName(), getNumPrimaryKeys());
- segment.enableUpsert(this, new ThreadSafeMutableRoaringBitmap(), null);
- return;
- }
- } else {
- validDocIds = null;
+ if (!_enableSnapshot) {
segment.deleteValidDocIdsSnapshot();
}
-
try (UpsertUtils.RecordInfoReader recordInfoReader = new
UpsertUtils.RecordInfoReader(segment, _primaryKeyColumns,
_comparisonColumns, _deleteRecordColumn)) {
- Iterator<RecordInfo> recordInfoIterator;
- if (validDocIds != null) {
- recordInfoIterator =
UpsertUtils.getRecordInfoIterator(recordInfoReader, validDocIds);
- } else {
- recordInfoIterator =
- UpsertUtils.getRecordInfoIterator(recordInfoReader,
segment.getSegmentMetadata().getTotalDocs());
- }
+ Iterator<RecordInfo> recordInfoIterator =
+ UpsertUtils.getRecordInfoIterator(recordInfoReader,
segment.getSegmentMetadata().getTotalDocs());
addSegment(segment, null, null, recordInfoIterator);
} catch (Exception e) {
throw new RuntimeException(
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]