gortiz commented on PR #13619: URL: https://github.com/apache/pinot/pull/13619#issuecomment-2230541255
> would be really interesting to see the Performance Impact of this. I don't expect an actual performance gain. In fact we tried virtual threads last summer and they were a bit less efficient than normal threads. That is expected and acceptable because in ideal situations these threads will not do any IO but mostly wait for other threads and heavy computation. The later is the worst case for virtual threads. But given the current multi-stage topology, the easiest way to ensure tasks not get blocked is to use cached thread pools, which means in case of large QPS we end up using too many threads and even worse, in constrained environments (ie CPU limits un k8s/docker) we can consume all the CPU quota with multi-stage threads, starving the rest of the system. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
