(pinot) branch master updated: add assertions for S3PinotFS move (#13631)

[jackie]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 0e5ad8ede1 add assertions for S3PinotFS move (#13631)
0e5ad8ede1 is described below

commit 0e5ad8ede19a28a6ce6b1c9595dadebbe49b4a60
Author: sullis <git...@seansullivan.com>
AuthorDate: Tue Jul 16 17:23:03 2024 -0700

    add assertions for S3PinotFS move (#13631)
---
 .../pinot/plugin/filesystem/S3PinotFSTest.java     | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)

diff --git 
a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
 
b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
index a41391034d..48224a359d 100644
--- 
a/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
+++ 
b/pinot-plugins/pinot-file-system/pinot-s3/src/test/java/org/apache/pinot/plugin/filesystem/S3PinotFSTest.java
@@ -433,6 +433,9 @@ public class S3PinotFSTest {
 
       _s3PinotFS.copyFromLocalFile(file, sourceUri);
 
+      HeadObjectResponse sourceHeadObjectResponse =
+          _s3Client.headObject(S3TestUtils.getHeadObjectRequest(BUCKET, 
fileName));
+
       URI targetUri = URI.create(String.format(FILE_FORMAT, SCHEME, BUCKET, 
"move-target"));
 
       boolean moveResult = _s3PinotFS.move(sourceUri, targetUri, false);
@@ -441,9 +444,24 @@ public class S3PinotFSTest {
       Assert.assertFalse(_s3PinotFS.exists(sourceUri));
       Assert.assertTrue(_s3PinotFS.exists(targetUri));
 
-      HeadObjectResponse headObjectResponse =
+      HeadObjectResponse targetHeadObjectResponse =
           _s3Client.headObject(S3TestUtils.getHeadObjectRequest(BUCKET, 
"move-target"));
-      Assert.assertEquals(headObjectResponse.contentLength(), fileSize);
+      Assert.assertEquals(targetHeadObjectResponse.contentLength(),
+          fileSize);
+      Assert.assertEquals(targetHeadObjectResponse.storageClass(),
+          sourceHeadObjectResponse.storageClass());
+      Assert.assertEquals(targetHeadObjectResponse.archiveStatus(),
+          sourceHeadObjectResponse.archiveStatus());
+      Assert.assertEquals(targetHeadObjectResponse.contentType(),
+          sourceHeadObjectResponse.contentType());
+      Assert.assertEquals(targetHeadObjectResponse.expiresString(),
+          sourceHeadObjectResponse.expiresString());
+      Assert.assertEquals(targetHeadObjectResponse.eTag(),
+          sourceHeadObjectResponse.eTag());
+      Assert.assertEquals(targetHeadObjectResponse.replicationStatusAsString(),
+          sourceHeadObjectResponse.replicationStatusAsString());
+      Assert.assertEquals(targetHeadObjectResponse.lastModified(),
+          sourceHeadObjectResponse.lastModified());
     } finally {
       FileUtils.deleteQuietly(file);
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org