siddharthteotia commented on PR #13639: URL: https://github.com/apache/pinot/pull/13639#issuecomment-2237547365
@gortiz - how will this work for existing segments in production that currently LBuffer writer and therefore depend on the corresponding reader ? I see that in https://github.com/apache/pinot/pull/13545 you mentioned about incrementally working towards deleting LArray starting by making the new implementation as default one. I understand that new segments will pick up the new writer (Unsafe based). But how do we take care of rebuilding existing segments ? We need to have an approach that will work for production users. Otherwise we will always have to keep the Larray reader code around. May be we should do something like we did for segment v2 -> v3 format migration? IIRC, during pre-processor we detected V2 and moved to V3. Thoughts @vvivekiyer @Jackie-Jiang ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
