vrajat commented on PR #13650: URL: https://github.com/apache/pinot/pull/13650#issuecomment-2241466108
> What is the postgreSQL behavior on this query? This is backward incompatible, and we need to be careful here Postgres behaviour is described in the description. This PR makes it similar to PG. Some more info on my investigation: Implicit conversion table of Calcite is in [SQL language](https://calcite.apache.org/docs/reference.html#implicit-type-conversion) It specifically states that string → int is an implicit conversion. This is different from PG. Char/Varchar → integer requires an explicit cast. The implicit conversions in PG can be seen with the following query: ``` SELECT casttarget::regtype AS target_type , castsource::regtype AS source_type , castcontext FROM pg_cast WHERE castcontext IN ('i', 'a') ORDER BY 1, 2; ``` I agree about being careful on breaking backward compatibility. One option is to add a flag for changes that make multi-stage strongly-typed. Has there been any discussions on flags to help move towards ANSI/PG SQL compatability? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
