shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697929757
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/DatabaseUtils.java:
##########
@@ -155,4 +157,18 @@ public static String extractDatabaseFromQueryRequest(
String database = databaseFromHeaders != null ? databaseFromHeaders :
databaseFromOptions;
return Objects.requireNonNullElse(database,
CommonConstants.DEFAULT_DATABASE);
}
+
+ /**
+ * Extract the database name from the prefix of fully qualified table name.
+ * If no prefix is present "default" database is returned
+ */
+ public static String extractDatabaseFromFullyQualifiedTableName(String
fullyQualifiedTableName) {
Review Comment:
`fullyQualifiedTableName = <databaseName>.<logicalTableName>`
and we allow the databaseName to be skipped or have `default` value for
backward compatibility hence table name without database prefix is also a valid
`fullyQualifiedTableName`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
