tibrewalpratik17 commented on code in PR #13347:
URL: https://github.com/apache/pinot/pull/13347#discussion_r1701487051
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java:
##########
@@ -81,6 +81,8 @@ public void init(TableConfig tableConfig, Schema schema,
TableDataManager tableD
.setPartialUpsertHandler(partialUpsertHandler).setEnableSnapshot(enableSnapshot).setEnablePreload(enablePreload)
.setMetadataTTL(metadataTTL).setDeletedKeysTTL(deletedKeysTTL).setConsistencyMode(_consistencyMode)
.setUpsertViewRefreshIntervalMs(upsertViewRefreshIntervalMs).setTableIndexDir(tableIndexDir)
+ .setDropOutOfOrderRecord(upsertConfig.isDropOutOfOrderRecord())
+ .setEnableConsistentDeletes(upsertConfig.isEnableConsistentDeletes())
Review Comment:
Yes but won't it become non-intuitive for users to put entire
`metadataManagerClass` instead of just enabling a boolean flag. Plus IMO we
might make a call in future to consolidate this class with the original class
and so that will make all existing tables using this `metadataManagerClass` as
backward-incompatible. Better to not strictly depend on className to enable
this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
