Jackie-Jiang commented on code in PR #13704:
URL: https://github.com/apache/pinot/pull/13704#discussion_r1712443355
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/recordtransformer/RecordEnricher.java:
##########
@@ -16,25 +16,21 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.pinot.spi.recordenricher;
-
-import java.util.List;
-import org.apache.pinot.spi.data.readers.GenericRow;
-
+package org.apache.pinot.segment.local.recordtransformer;
/**
* Interface for enriching records.
* If a column with the same name as the input column already exists in the
record, it will be overwritten.
*/
-public interface RecordEnricher {
- /**
- * Returns the list of input columns required for enriching the record.
- * This is used to make sure the required input fields are extracted.
- */
- List<String> getInputColumns();
-
- /**
- * Enriches the given record, by adding new columns to the same record.
- */
- void enrich(GenericRow record);
-}
+//public interface RecordEnricher {
Review Comment:
Please cleanup the commented lines, and files that are no longer needed.
Same for other places
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java:
##########
@@ -129,7 +129,7 @@ public void build(@Nullable SegmentVersion segmentVersion,
ServerMetrics serverM
recordReader.init(_realtimeSegmentImpl, sortedDocIds);
RealtimeSegmentSegmentCreationDataSource dataSource =
new RealtimeSegmentSegmentCreationDataSource(_realtimeSegmentImpl,
recordReader);
- driver.init(genConfig, dataSource,
RecordEnricherPipeline.getPassThroughPipeline(),
+ driver.init(genConfig, dataSource,
RecordTransformerPipeline.getPassThroughPipeline(),
Review Comment:
We want to integrate the current `RecordEnricher` as one type of
`RecordTransformer`. With that, we shouldn't need a separate pipeline other
than `TransformPipeline`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
