real-mj-song commented on PR #13805: URL: https://github.com/apache/pinot/pull/13805#issuecomment-2286808911
Yes this change should support those mixed env scenarios (at least in terms of getting local address). Expanding what I described in PR description, these will be the behavior after this change vs before. * everything in ipv6 only: **currently broken**. will start working (ℹ️ Linkedin usecase) * everything in ipv4 only: should work the same * dual stack with `preferIPv6Addresses`: currently using ipv4 regardless of flag. will start using ipv6 internally. (ℹ️ Linkedin usecase) * dual stack with no `preferIPv6Addresses`: will use ipv4 to communicate * one ipv6 only broker host and others dual stack brokers: should be able to communicate in ipv6 * ipv6 only brokers and dual stack servers (or the other way around) with `preferIPv6Addresses`: should be able to communicate in ipv6 (ℹ️ Linkedin usecase) * ipv4 only brokers and dual stack servers (or the other way around): should work the same -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org