rfscholte commented on code in PR #13845:
URL: https://github.com/apache/pinot/pull/13845#discussion_r1722094701
##########
pinot-spi/pom.xml:
##########
@@ -73,6 +73,11 @@
<artifactId>commons-codec</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.codehaus.plexus</groupId>
+ <artifactId>plexus-classworlds</artifactId>
+ <version>2.8.0</version>
+ </dependency>
Review Comment:
It is a matter of taste. If it is just for one dependency that is only used
in 1 module, it might feel like overhead. However, if the project has this
style, that's perfectly fine. At least you know where to find the version of
any dependency.
I'll redeclare it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
