gortiz commented on code in PR #13907:
URL: https://github.com/apache/pinot/pull/13907#discussion_r1740998881
##########
pinot-spi/src/test/java/org/apache/pinot/spi/plugin/PluginsDirectoryVisitorTest.java:
##########
@@ -0,0 +1,33 @@
+package org.apache.pinot.spi.plugin;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Set;
+import org.testng.annotations.Test;
+
+import static org.testng.Assert.*;
+
+
+public class PluginsDirectoryVisitorTest {
+
+ private final PinotPluginHandler _pinotPluginHandler = new
PinotPluginHandler();
+ private final ShadedPluginHandler _shadedPluginHandler = new
ShadedPluginHandler();
+
+ @Test
+ public void testVisitDirectory() {
+ PluginsDirectoryVisitor visitor = new
PluginsDirectoryVisitor(_pinotPluginHandler, _shadedPluginHandler);
+
+ Path pluginsDirectory = Path.of("src/test/resources/plugins-directory");
+ try {
+ Files.walkFileTree(pluginsDirectory, Set.of(), 1, visitor);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+
+ assertEquals(visitor.getPluginDirs().size(), 3);
+
assertTrue(visitor.getPluginDirs().contains(Path.of("src/test/resources/plugins-directory/shadedplugin-1")));
+
assertTrue(visitor.getPluginDirs().contains(Path.of("src/test/resources/plugins-directory/pinotplugin-1")));
+
assertTrue(visitor.getPluginDirs().contains(Path.of("src/test/resources/plugins-directory/pinotplugin-2")));
+ }
+}
Review Comment:
Probably checkstyle will complain asking for a new EOL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
