gortiz commented on code in PR #13733: URL: https://github.com/apache/pinot/pull/13733#discussion_r1749925095
########## pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiStageEngineExplainIntegrationTest.java: ########## @@ -0,0 +1,255 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.integration.tests; + +import com.fasterxml.jackson.databind.JsonNode; +import java.io.File; +import java.util.List; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.data.Schema; +import org.apache.pinot.spi.env.PinotConfiguration; +import org.apache.pinot.spi.utils.CommonConstants; +import org.apache.pinot.util.TestUtils; +import org.intellij.lang.annotations.Language; +import org.testcontainers.shaded.org.apache.commons.io.FileUtils; +import org.testng.Assert; +import org.testng.annotations.AfterClass; +import org.testng.annotations.BeforeClass; +import org.testng.annotations.BeforeMethod; +import org.testng.annotations.Test; + + +public class MultiStageEngineExplainIntegrationTest extends BaseClusterIntegrationTest { + private static final String SCHEMA_FILE_NAME = "On_Time_On_Time_Performance_2014_100k_subset_nonulls.schema"; + private static final String DEFAULT_DATABASE_NAME = CommonConstants.DEFAULT_DATABASE; + private static final String DATABASE_NAME = "db1"; + private static final String TABLE_NAME_WITH_DATABASE = DATABASE_NAME + "." + DEFAULT_TABLE_NAME; + private String _tableName = DEFAULT_TABLE_NAME; + + @Override + protected String getSchemaFileName() { + return SCHEMA_FILE_NAME; + } + + @BeforeClass + public void setUp() + throws Exception { + TestUtils.ensureDirectoriesExistAndEmpty(_tempDir, _segmentDir, _tarDir); + + // Start the Pinot cluster + startZk(); + startController(); + startBroker(); + startServers(2); + + // Create and upload the schema and table config + Schema schema = createSchema(); + addSchema(schema); + TableConfig tableConfig = createOfflineTableConfig(); + addTableConfig(tableConfig); + + // Unpack the Avro files + List<File> avroFiles = unpackAvroData(_tempDir); + + // Create and upload segments + ClusterIntegrationTestUtils.buildSegmentsFromAvro(avroFiles, tableConfig, schema, 0, _segmentDir, _tarDir); + uploadSegments(getTableName(), _tarDir); + + // Wait for all documents loaded + waitForAllDocsLoaded(600_000L); + } + + protected void overrideBrokerConf(PinotConfiguration brokerConf) { + brokerConf.setProperty(CommonConstants.MultiStageQueryRunner.ASK_SERVERS_FOR_EXPLAIN_PLAN, "true"); + } + + @BeforeMethod + public void resetMultiStage() { + setUseMultiStageQueryEngine(true); + } + + @Test + public void simpleQuery() { + explain("SELECT 1 FROM mytable", + //@formatter:off + "Execution Plan\n" + + "PinotLogicalExchange(distribution=[broadcast])\n" + + " LEAF_STAGE_COMBINE_OPERATOR\n" + + " STREAMING_INSTANCE_RESPONSE\n" + + " STREAMING_COMBINE_SELECT(repeatedOnSegments=[12])\n" + + " SELECT_STREAMING(totalDocs=[115545])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[120000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[115545])\n"); + //@formatter:on + } + + @Test + public void simpleQueryVerbose() { + explainVerbose("SELECT 1 FROM mytable", + //@formatter:off + "Execution Plan\n" + + "IntermediateCombine\n" + + " Alternative(servers=[1])\n" + + " PinotLogicalExchange(distribution=[broadcast])\n" + + " LEAF_STAGE_COMBINE_OPERATOR\n" + + " STREAMING_INSTANCE_RESPONSE\n" + + " STREAMING_COMBINE_SELECT\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " Alternative(servers=[1])\n" + + " PinotLogicalExchange(distribution=[broadcast])\n" + + " LEAF_STAGE_COMBINE_OPERATOR\n" + + " STREAMING_INSTANCE_RESPONSE\n" + + " STREAMING_COMBINE_SELECT\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n" + + " SELECT_STREAMING(segment=[any], totalDocs=[any])\n" + + " TRANSFORM(expressions=[[\"'1'\"]])\n" + + " PROJECT(columns=[[]])\n" + + " DOC_ID_SET(maxDocs=[10000])\n" + + " FILTER_MATCH_ENTIRE_SEGMENT(numDocs=[any])\n"); + //@formatter:on + } + + @Test + public void simpleQueryLogical() { + explainLogical("SELECT 1 FROM mytable", + //@formatter:off + "Execution Plan\n" + + "LogicalProject(EXPR$0=[1])\n" + + " LogicalTableScan(table=[[default, mytable]])\n"); + //@formatter:on + } + + @Override + protected String getTableName() { + return _tableName; + } Review Comment: I just copied it from MultiStageEngineIntegrationTest, which was actually changing the value :D. I'm going to remove it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
