Jackie-Jiang commented on code in PR #13967:
URL: https://github.com/apache/pinot/pull/13967#discussion_r1751047670
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/LookupTransformFunction.java:
##########
@@ -219,8 +218,7 @@ private void lookup(ValueBlock valueBlock, ValueAcceptor
valueAcceptor) {
}
}
// lookup
- GenericRow row = _dataManager.lookupRowByPrimaryKey(primaryKey);
- Object value = row == null ? null : row.getValue(_dimColumnName);
+ Object value = _dataManager.lookupValue(primaryKey, _dimColumnName);
Review Comment:
Sharp eyes! Yes it is a preparation for #13966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
