Jackie-Jiang commented on code in PR #13954:
URL: https://github.com/apache/pinot/pull/13954#discussion_r1752532896
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelper.java:
##########
@@ -542,6 +549,12 @@ public static List<String>
getInstancesWithTag(List<InstanceConfig> instanceConf
return
instancesWithTag.stream().map(InstanceConfig::getInstanceName).collect(Collectors.toList());
}
+ public static List<String> getInstancesWithoutTag(List<InstanceConfig>
instanceConfigs, String tag) {
+ List<InstanceConfig> instancesWithoutTag =
getInstancesConfigsWithoutTag(instanceConfigs, tag);
+ return
instancesWithoutTag.stream().map(InstanceConfig::getInstanceName).collect(Collectors.toList());
+ }
+
Review Comment:
(minor) Remove extra empty line
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/helix/HelixHelper.java:
##########
@@ -552,6 +565,17 @@ public static List<InstanceConfig>
getInstancesConfigsWithTag(List<InstanceConfi
return instancesWithTag;
}
+ public static List<InstanceConfig>
getInstancesConfigsWithoutTag(List<InstanceConfig> instanceConfigs, String tag)
{
Review Comment:
Suggest changing `tag` to `defaultTag` and add some javadoc explaining this
is the tag representing that there is no tag associated with the instance. Same
for other methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
