Jackie-Jiang commented on code in PR #13968:
URL: https://github.com/apache/pinot/pull/13968#discussion_r1752775647
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -4287,6 +4287,27 @@ public Map<String, Integer>
minimumInstancesRequiredForTags() {
return tagMinInstanceMap;
}
+ public boolean isSegmentRevertedInConsistentPush(String segmentName, String
tableNameWithType) {
+ SegmentLineage segmentLineage =
SegmentLineageAccessHelper.getSegmentLineage(_propertyStore, tableNameWithType);
+ return isSegmentRevertedInConsistentPush(segmentName, segmentLineage);
+ }
+
+ @VisibleForTesting
+ static boolean isSegmentRevertedInConsistentPush(String segmentName,
SegmentLineage segmentLineage) {
Review Comment:
```suggestion
static boolean isSegmentRevertedInConsistentPush(String segmentName,
@Nullable SegmentLineage segmentLineage) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
