gortiz commented on code in PR #13955:
URL: https://github.com/apache/pinot/pull/13955#discussion_r1753321639
##########
pinot-core/src/main/java/org/apache/pinot/core/accounting/PerQueryCPUMemAccountantFactory.java:
##########
@@ -157,6 +160,11 @@ public
PerQueryCPUMemResourceUsageAccountant(PinotConfiguration config, String i
LOGGER.info("_isThreadCPUSamplingEnabled: {},
_isThreadMemorySamplingEnabled: {}", _isThreadCPUSamplingEnabled,
_isThreadMemorySamplingEnabled);
+ _isThreadSamplingEnabledForMSE =
+
config.getProperty(CommonConstants.Accounting.CONFIG_OF_ENABLE_THREAD_SAMPLING_MSE,
+ CommonConstants.Accounting.DEFAULT_ENABLE_THREAD_SAMPLING_MSE);
+ LOGGER.info("_isThreadSamplingEnabledForMSE: {}",
_isThreadSamplingEnabledForMSE);
Review Comment:
nit: I don't think using the attribute name is a good idea. Specially in
case it changes in the future. Instead something like: `Thread sampling enabled
for MSE: true/false`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
