gortiz commented on code in PR #13746: URL: https://github.com/apache/pinot/pull/13746#discussion_r1771474421
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -359,6 +359,8 @@ public static class Broker { public static class Request { public static final String SQL = "sql"; + public static final String V1SQL = "v1sql"; Review Comment: My order of preference in descending order is: 1. `sqlV1` and `sqlV2` so they start with the same prefix of the default `sql`. 2. `v1Sql` and `v2Sql` 3. `sse` and `mse` sound a bit strange. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org