ankitsultana commented on code in PR #13999:
URL: https://github.com/apache/pinot/pull/13999#discussion_r1771620365
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -441,7 +444,15 @@ private InstanceResponseBlock
executeInternal(TableDataManager tableDataManager,
if (queryContext.isExplain()) {
instanceResponse =
getExplainResponseForNoMatchingSegment(numTotalSegments, queryContext);
} else {
- instanceResponse = new
InstanceResponseBlock(ResultsBlockUtils.buildEmptyQueryResults(queryContext));
+ if (QueryContextUtils.isTimeSeriesQuery(queryContext)) {
+ // TODO: handle invalid segments
+ TimeSeriesBlock seriesBlock = new TimeSeriesBlock(
+ queryContext.getTimeSeriesContext().getTimeBuckets(),
Collections.emptyMap());
+ TimeSeriesResultsBlock resultsBlock = new
TimeSeriesResultsBlock(seriesBlock);
+ instanceResponse = new InstanceResponseBlock(resultsBlock);
Review Comment:
Yeah we could move it there. I can raise a follow-up PR if required. Lmk
@gortiz
re: tests, that's expected. We are trying to get a Quickstart working right
now. Once the Part-4 PR is merged we will start raising smaller PRs with tests,
bug fixes and other improvements.
Test coverage should be fixed in October.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
