deemoliu commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803909404


##########
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##########
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
   private TarCompressionUtils() {
   }
 
+  /**
+   * This generic compressed tar file extension does not bind to a particular 
compressor. Decompression determines the
+   * appropriate compressor at run-time based on the file's magic number 
irrespective of the file extension.
+   * Compression uses the default compressor automatically if this generic 
extension is used.
+   */
+  public static final String TAR_COMPRESSED_FILE_EXTENSION = ".tar.compressed";

Review Comment:
   sounds good, so we using the first bytes to identify which decompressor to 
use. the apache library initializes the correct compressor for us.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to