yashmayya commented on code in PR #14249:
URL: https://github.com/apache/pinot/pull/14249#discussion_r1804915226
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/window/aggregate/AggregateWindowFunction.java:
##########
@@ -49,54 +50,198 @@ public AggregateWindowFunction(RexExpression.FunctionCall
aggCall, DataSchema in
@Override
public final List<Object> processRows(List<Object[]> rows) {
- if (_partitionByOnly) {
- return processPartitionOnlyRows(rows);
Review Comment:
I'd initially removed this optimization to reduce clutter since there are a
lot of different cases being handled in the new function implementation.
However, on second thoughts, the optimization to avoid key computation (among
other things) for each row might be significant enough to be worth retaining?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
