shounakmk219 commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808135587
########## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ########## @@ -81,15 +81,32 @@ public class HelixExternalViewBasedQueryQuotaManager implements ClusterChangeHan private final AtomicInteger _lastKnownBrokerResourceVersion = new AtomicInteger(-1); private final Map<String, QueryQuotaEntity> _rateLimiterMap = new ConcurrentHashMap<>(); private final Map<String, QueryQuotaEntity> _databaseRateLimiterMap = new ConcurrentHashMap<>(); + private final Map<String, QueryQuotaEntity> _applicationRateLimiterMap = new ConcurrentHashMap<>(); private double _defaultQpsQuotaForDatabase; + private double _defaultQpsQuotaForApplication; Review Comment: Got it, thanks for the explanation. Can you add a point around this in PR description as well? Also consider exposing a metric that tracks the number of active applications being monitored by the rate limiter map as its an unbounded map and not sure how this will be leveraged by users so having those insights would help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
