gortiz commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1808556078
##########
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BaseBrokerStarter.java:
##########
@@ -346,9 +352,38 @@ public void start()
timeSeriesRequestHandler = new TimeSeriesRequestHandler(_brokerConf,
brokerId, _routingManager,
_accessControlFactory, _queryQuotaManager, tableCache,
queryDispatcher);
}
+
+ LOGGER.info("Initializing PinotFSFactory");
+
PinotFSFactory.init(_brokerConf.subset(CommonConstants.Broker.PREFIX_OF_CONFIG_OF_PINOT_FS_FACTORY));
+
+ LOGGER.info("Initialize ResultStore");
+ PinotConfiguration resultStoreConfiguration =
+
_brokerConf.subset(CommonConstants.CursorConfigs.PREFIX_OF_CONFIG_OF_RESULT_STORE);
+ try {
+ ResponseSerde responseSerde =
ResponseSerdeService.getInstance().getResponseSerde(
+
resultStoreConfiguration.getProperty(CommonConstants.CursorConfigs.RESULT_STORE_SERDE,
+ CommonConstants.CursorConfigs.DEFAULT_RESULT_SERDE));
+
responseSerde.init(resultStoreConfiguration.subset(CommonConstants.CursorConfigs.RESULT_STORE_SERDE)
+ .subset(responseSerde.getType()));
+
+ String expirationTime =
getConfig().getProperty(CommonConstants.CursorConfigs.RESULTS_EXPIRATION_INTERVAL,
+ CommonConstants.CursorConfigs.DEFAULT_RESULTS_EXPIRATION_INTERVAL);
+
+ _resultStore = (AbstractResponseStore)
ResponseStoreService.getInstance().getResultStore(
Review Comment:
This doesn't look pretty. Here we are effectibly enforcing that
`ResponseStoreService.getInstance().getResultStore(whatever)` should always
return an `AbstractResponseStore`. If that is the case we should change the
`getResultStore` method to enforce that at compile time. Alternatively we could
relax the requirements in this class to be able to work with a `ResponseStore`
(the interface)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
