vrajat commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1809382280
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##########
@@ -46,13 +50,23 @@ public class BrokerRequestHandlerDelegate implements
BrokerRequestHandler {
private final BaseSingleStageBrokerRequestHandler
_singleStageBrokerRequestHandler;
private final MultiStageBrokerRequestHandler _multiStageBrokerRequestHandler;
private final TimeSeriesRequestHandler _timeSeriesRequestHandler;
+ private final AbstractResponseStore _resultStore;
+ private final String _brokerHost;
+ private final int _brokerPort;
+ private final long _expirationIntervalInMs;
+
public BrokerRequestHandlerDelegate(BaseSingleStageBrokerRequestHandler
singleStageBrokerRequestHandler,
@Nullable MultiStageBrokerRequestHandler multiStageBrokerRequestHandler,
- @Nullable TimeSeriesRequestHandler timeSeriesRequestHandler) {
+ @Nullable TimeSeriesRequestHandler timeSeriesRequestHandler,
+ String brokerHost, int brokerPort, AbstractResponseStore resultStore,
String expirationTime) {
_singleStageBrokerRequestHandler = singleStageBrokerRequestHandler;
_multiStageBrokerRequestHandler = multiStageBrokerRequestHandler;
_timeSeriesRequestHandler = timeSeriesRequestHandler;
+ _brokerHost = brokerHost;
+ _brokerPort = brokerPort;
+ _resultStore = resultStore;
+ _expirationIntervalInMs = TimeUtils.convertPeriodToMillis(expirationTime);
Review Comment:
`BaseBrokerStarter` is executed only at startup. So what you are suggesting
is how it works right now. This code is executed in process startup. So if
there is an error, the startup will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
