gortiz commented on PR #14275: URL: https://github.com/apache/pinot/pull/14275#issuecomment-2429426508
> any particular reason why we're introducing the config here even though we won't support it being turned on? Why not simply make it off by default and introduce the config when the issue with the dispatch client is fixed? We could just rollback #13645, but I think most of the changes from @anandheritage can be kept. It is just a matter of enabling TLS in the client side. What we are also going to need for sure is a property to enable/disable TLS between broker and server in multi-stage. But maybe you are right, just disable it would be better. Mainly because configs are pretty complex right now and my property would also require to add a similar (but slightly different) property for brokers in future. Therefore I'm going to approve the rollback from @soumitra-st (https://github.com/apache/pinot/pull/14259) and then we can implement TLS with more time to think about how to configure it easily. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
