gortiz opened a new pull request, #14290:
URL: https://github.com/apache/pinot/pull/14290
We have been (ab)using of `//@formatter:off` to be able to write things like:
```
//@formatter:off
QueryEnvironment queryEnvironment = new
QueryEnvironment(QueryEnvironment.configBuilder()
.database(database)
.tableCache(_tableCache)
.workerManager(_workerManager)
.defaultInferPartitionHint(inferPartitionHint)
.build());
//@formatter:on
```
Otherwise Intellij formatter will reformat that to:
```
QueryEnvironment queryEnvironment = new QueryEnvironment(
QueryEnvironment.configBuilder().database(database).tableCache(_tableCache).workerManager(_workerManager)
.defaultInferPartitionHint(inferPartitionHint).build());
```
Which for several of us is more difficult to read, specially when reviewing
PRs that modify something in the chain.
This PR changes the config in intellij to automatically use the first
option. In intellij nomenclature the current mode is _wrap if long_ and the new
one is _chop if long_.
The side effect of this PR is that intellij may reformat some lines to the
chop format. If we don't want that we can also configure Intellij to simply do
not modify these chained methods, which would give each developer the choice to
use one or the other format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
