jadami10 commented on code in PR #11869:
URL: https://github.com/apache/pinot/pull/11869#discussion_r1815599729
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/IngestionConfigUtils.java:
##########
@@ -116,7 +117,7 @@ public static String
getBatchSegmentIngestionType(TableConfig tableConfig) {
if (segmentIngestionType == null) {
segmentIngestionType =
tableConfig.getValidationConfig().getSegmentPushType();
}
- return segmentIngestionType;
+ return (segmentIngestionType == null) ? DEFAULT_SEGMENT_INGESTION_TYPE :
segmentIngestionType;
Review Comment:
> We shouldn't allow empty push type which doesn't match APPEND or REFRESH.
Agreed. Though it's not clear to me where we would put this logic since
REALTIME table configs are ok with this being unset.
> Since we are already making it default to APPEND, and this has been merged
for 1 year, I guess we need to follow this going forward.
Looks like this PR added a unit test in
`pinot-spi/src/test/java/org/apache/pinot/spi/utils/IngestionConfigUtilsTest.java`
to assert the default is now `APPEND`. So this is probably fine going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]