Jackie-Jiang commented on code in PR #14338:
URL: https://github.com/apache/pinot/pull/14338#discussion_r1823408827
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java:
##########
@@ -217,8 +217,7 @@ public DataBlock.Type getType() {
*
* @return whether this block is the end of stream.
*/
- // TODO: Update the name to isTerminateBlock.
Review Comment:
This is a very old `TODO` (added in 2022), and since everyone is used to
`isEndOfStreamBlock()` and `isSuccessfulEndOfStreamBlock()`, renaming it could
cause more confusion. We can probably just remove this TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
