vrajat commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1827413506
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##########
@@ -46,13 +50,23 @@ public class BrokerRequestHandlerDelegate implements
BrokerRequestHandler {
private final BaseSingleStageBrokerRequestHandler
_singleStageBrokerRequestHandler;
Review Comment:
Can you review again ? I've moved much of the implementation to
`AbstractResponseStore`. So the class delegates all the cursor work to this
class.
The original implementation did have `CursorBrokerRequestHandler` and it
mostly copied this class's logic. I tried to consolidate the code and it wasnt
clean. Instead I chose to use composition and that seems to be the preferred
pattern as `TimeSeriesRequestHandler` has also been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
