jackluo923 commented on PR #14363: URL: https://github.com/apache/pinot/pull/14363#issuecomment-2460966720
> Can you elaborate more on why text search might use long identifier? Identifier is column name, instead of literal. What is the overhead of increasing it? I have updated the PR description which explains the problem better. I don't think there is any overhead of increasing it as it is an artificial limit within the sql parser. For cases where the identifier does not exceed 128 characters, the overhead should be the same. For identifiers that exceeds 128 characters, we haven't noticed any observable overhead since query parsing constitute minimal run-time overhead compared to the query itself. It is extremely rare to encounter identifiers over 128 characters, but if we do encounter it, with this PR, queries will still be able to complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
