itschrispeck commented on code in PR #14444:
URL: https://github.com/apache/pinot/pull/14444#discussion_r1844709969
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##########
@@ -182,6 +182,14 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
LOGGER.info("Creating dictionary index in column {}.{} even when it
is disabled in config",
segmentCreationSpec.getTableName(), columnName);
}
+
+ // override dictionary type if configured to do so
+ if (_config.isOptimizeDictionaryType()) {
+ LOGGER.info("Overriding dictionary type for column: {} using
var-length dictionary: {}", columnName,
+ columnIndexCreationInfo.isUseVarLengthDictionary());
+ dictConfig = new DictionaryIndexConfig(dictConfig,
columnIndexCreationInfo.isUseVarLengthDictionary());
Review Comment:
It is whichever is specified in the table config, the addition option will
ignore the static config and use column index creation info - it does not
necessary go var -> fixed or fixed -> var, so I think naming should stay
generic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
