shounakmk219 commented on code in PR #14425:
URL: https://github.com/apache/pinot/pull/14425#discussion_r1845844340
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/mapper/SegmentMapper.java:
##########
@@ -180,13 +188,11 @@ private boolean completeMapAndTransformRow(RecordReader
recordReader, GenericRow
reuse = recordReader.next(reuse);
_recordEnricherPipeline.run(reuse);
- if (reuse.getValue(GenericRow.MULTIPLE_RECORDS_KEY) != null) {
- //noinspection unchecked
- for (GenericRow row : (Collection<GenericRow>)
reuse.getValue(GenericRow.MULTIPLE_RECORDS_KEY)) {
- transformAndWrite(row);
+ _transformPipeline.processRow(reuse, reusedResult);
Review Comment:
Yes it does the same thing as transformAndWrite minus the `writeRecord` part
which is called separately below.
Actually `IngestionUtils.shouldIngestRow(transformedRow)` check is also
applied in `processRow` while building the `reusedResult` so I'll remove that
check from here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
