deemoliu commented on code in PR #14496:
URL: https://github.com/apache/pinot/pull/14496#discussion_r1849100434
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarUtils.java:
##########
@@ -84,7 +84,7 @@ static StreamMessageMetadata
extractMessageMetadata(Message<byte[]> message, Pul
MessageIdStreamOffset nextOffset = new
MessageIdStreamOffset(getNextMessageId(messageId));
StreamMessageMetadata.Builder builder =
new
StreamMessageMetadata.Builder().setRecordIngestionTimeMs(recordIngestionTimeMs)
- .setOffset(offset, nextOffset);
+ .setOffset(offset,
nextOffset).setSerializedValueSize(message.size());
Review Comment:
null check if message can be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
