ankitsultana commented on code in PR #14494:
URL: https://github.com/apache/pinot/pull/14494#discussion_r1849043166
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -425,13 +426,14 @@ public SuccessResponse reloadSegment(
/**
* Helper method to find the existing table based on the given table name
(with or without type suffix) and segment
* name.
- * TODO: Real-time table might also contain uploaded segments (not with LLC
name), which is not handled here.
*/
private String getExistingTable(String tableName, String segmentName) {
TableType tableType =
TableNameBuilder.getTableTypeFromTableName(tableName);
if (tableType == null) {
// Derive table type from segment name if the given table name doesn't
have type suffix
- tableType = LLCSegmentName.isLLCSegment(segmentName) ?
TableType.REALTIME : TableType.OFFLINE;
+ tableType = LLCSegmentName.isLLCSegment(segmentName) ? TableType.REALTIME
+ :
(UploadedRealtimeSegmentName.isUploadedRealtimeSegmentName(segmentName) ?
TableType.REALTIME
Review Comment:
Lgtm but ideally this should be a utility method somewhere. @Jackie-Jiang :
I saw that you marked `SegmentName` as deprecated as part of removing HLC code.
It only has 2 methods now both of which seem unused. Would it make sense to
unmark it as Deprecated and keep this logic there?
Otherwise I feel like this is a common bug folks will run into
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
