itachiunited commented on PR #14535: URL: https://github.com/apache/pinot/pull/14535#issuecomment-2499238504
> High level question: Is it watcher based triggering right now? Seems `reloadSslFactoryWhenFileStoreChanges()` is also executed in a separate executor, is it possible to have a single entry point which monitors both triggering condition and interval? @Jackie-Jiang - Yes, the current flow is watcher based. We want to keep both separate since this is a backup to make sure that the certs are reloaded everyday. FileWatcher thread just has to run once after restart to set up the FileWatcher and the new executor is to make sure that it runs once a day to reload the SSL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
