yashmayya commented on code in PR #14452:
URL: https://github.com/apache/pinot/pull/14452#discussion_r1865248601
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##########
@@ -140,7 +140,9 @@ public abstract class BaseSingleStageBrokerRequestHandler
extends BaseBrokerRequ
protected final int _defaultHllLog2m;
protected final boolean _enableQueryLimitOverride;
protected final boolean _enableDistinctCountBitmapOverride;
- protected final int _queryResponseLimit;
+ protected final int _queryResponseLimitOverride;
+ // if >= 0, then overrides default limit of 10, otherwise setting is ignored
+ protected final int _defaultQueryResponseLimit;
Review Comment:
```suggestion
protected final int _defaultQueryLimit;
```
nit: to align with the config name
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -255,7 +255,14 @@ public static class Broker {
public static final String CONFIG_OF_BROKER_QUERY_REWRITER_CLASS_NAMES =
"pinot.broker.query.rewriter.class.names";
public static final String CONFIG_OF_BROKER_QUERY_RESPONSE_LIMIT =
"pinot.broker.query.response.limit";
- public static final int DEFAULT_BROKER_QUERY_RESPONSE_LIMIT =
Integer.MAX_VALUE;
+ public static final String CONFIG_OF_BROKER_DEFAULT_QUERY_LIMIT =
+ "pinot.broker.default.query.limit";
+
+ public static final int DEFAULT_BROKER_QUERY_LIMIT_OVERRIDE =
Integer.MAX_VALUE;
+
+ // -1 means no limit; value of 10 aligns limit with PinotQuery's defaults.
+ public static final int DEFAULT_BROKER_QUERY_RESPONSE_LIMIT = 10;
Review Comment:
```suggestion
public static final int DEFAULT_BROKER_QUERY_LIMIT = 10;
```
nit: to align with the config name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
