yashmayya commented on code in PR #14110:
URL: https://github.com/apache/pinot/pull/14110#discussion_r1870669987
##########
pinot-broker/src/main/java/org/apache/pinot/broker/cursors/FsResponseStore.java:
##########
@@ -238,7 +238,7 @@ protected long writeResultTable(String requestId,
ResultTable resultTable)
try {
pinotFS.copyFromLocalFile(tempResultTableFile.toFile(), dataFile);
- return pinotFS.length(dataFile);
+ return tempResultTableFile.toFile().length();
Review Comment:
nit: each call to `toFile` is allocating a new `File` object - can be
consolidated into a single call and reused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
