tibrewalpratik17 commented on code in PR #14477:
URL: https://github.com/apache/pinot/pull/14477#discussion_r1871891863
##########
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java:
##########
@@ -199,4 +200,59 @@ public static class UpsertCompactionTask {
*/
public static final String NUM_SEGMENTS_BATCH_PER_SERVER_REQUEST =
"numSegmentsBatchPerServerRequest";
}
+
+ public static class UpsertCompactMergeTask {
Review Comment:
So with merge-compaction we would end up creating a new segment and refresh
would just go and do a replaceSegment flow in metadata-manager. For refresh of
LLC segment we should be good as the newly generated UploadedRealtimeSegment
would override the keys which it should.
For refresh of UploadedRealtimeSegment, there's an issue right now where we
use creation time to resolve for the latest uploaded segment, now there can be
an edge case where creation time is same for both then whichever gets refreshed
/ uploaded later would dominate. But overall if you see it doesn't matter in
the broad sense because for upserts we would still point to just one record per
key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
