raghavyadav01 commented on code in PR #14598:
URL: https://github.com/apache/pinot/pull/14598#discussion_r1872226477
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/QueryRunner.java:
##########
@@ -261,15 +264,15 @@ public void processTimeSeriesQuery(String serializedPlan,
Map<String, String> me
responseObserver.onCompleted();
};
try {
- final long timeoutMs = extractTimeoutMs(metadata);
- Preconditions.checkState(timeoutMs > 0,
- "Query timed out before getting processed in server. Remaining time:
%s", timeoutMs);
+ final long deadlineMs = extractDeadlineMs(metadata);
Review Comment:
Is it a timeout or deadline? If it is timeout then the pre check below seems
odd?
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/timeseries/PhysicalTimeSeriesServerPlanVisitor.java:
##########
@@ -42,17 +42,14 @@
import org.apache.pinot.tsdb.spi.plan.LeafTimeSeriesPlanNode;
-public class PhysicalTimeSeriesPlanVisitor {
- public static final PhysicalTimeSeriesPlanVisitor INSTANCE = new
PhysicalTimeSeriesPlanVisitor();
-
+public class PhysicalTimeSeriesServerPlanVisitor {
private QueryExecutor _queryExecutor;
private ExecutorService _executorService;
private ServerMetrics _serverMetrics;
- private PhysicalTimeSeriesPlanVisitor() {
- }
-
- public void init(QueryExecutor queryExecutor, ExecutorService
executorService, ServerMetrics serverMetrics) {
+ // Warning: Don't use singleton access pattern, since Quickstarts run in a
single JVM and spawn multiple broker/server
Review Comment:
Is this issue visible when multiple broker instances are running?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
