Harnoor7 commented on code in PR #14623:
URL: https://github.com/apache/pinot/pull/14623#discussion_r1877724647
##########
pinot-common/src/main/java/org/apache/pinot/common/minion/RealtimeToOfflineSegmentsTaskMetadata.java:
##########
@@ -41,19 +47,37 @@
public class RealtimeToOfflineSegmentsTaskMetadata extends BaseTaskMetadata {
private static final String WATERMARK_KEY = "watermarkMs";
+ private static final String SEGMENT_NAME_SEPARATOR = ",";
private final String _tableNameWithType;
- private final long _watermarkMs;
+ private long _watermarkMs;
+ private final Map<String, List<String>>
_realtimeSegmentVsCorrespondingOfflineSegmentMap;
Review Comment:
This code handles M -> N segment conversion. This edge case is handled
currently as well, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
