Jackie-Jiang commented on code in PR #14630:
URL: https://github.com/apache/pinot/pull/14630#discussion_r1880739219
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3837,6 +3838,11 @@ public void endReplaceSegments(String tableNameWithType,
String segmentLineageEn
tableNameWithType, segmentLineageEntryId);
}
+ // Can be overridden to provide custom logic
Review Comment:
This is replacing segment, not refreshing segment.
+1 on @vvivekiyer 's comment. Please document an example operations that
might be needed here. Also, do you want to also include `segmentsFrom`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
