gortiz commented on issue #14640: URL: https://github.com/apache/pinot/issues/14640#issuecomment-2540842204
AFAIK this includes two independent changes: 1. Push larger parts of the query into the leaf stage. 2. Execute the final reduce phase in the broker. While I agree 1 would be better, I don't get why 2 is important. I think the fact that in MSQ brokers do not need to execute the final reduce phase is a feature. It means we can have smaller brokers. Although it may have an impact in the performance, it shouldn't be that large. Before https://github.com/apache/pinot/pull/13303 MSQ spent a lot of time and resources during serialization/deserialization, which means that the cost of adding a new stage (like reducing in servers) was not trivial. But after that PR this cost should not be noticeable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
