ilamhs commented on issue #14595: URL: https://github.com/apache/pinot/issues/14595#issuecomment-2549325636
I have a related PR (https://github.com/apache/pinot/pull/14414) that adds a `Http Request` object to the *AccessControlFactory and I am realizing any changes in the interface is harder to do. I was wondering if the interface should instead be migrated to `boolean hasAccess(AccessControlRequest request)` and that request object has all the fields which are required and optional present making any extensions there easier. Yes, it will be slightly involved to keep it backward compatible in a Deprecated mode till a major version is released. Let me know what you think and how I can proceed with the other PR, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
