yashmayya opened a new pull request, #14753: URL: https://github.com/apache/pinot/pull/14753
- https://github.com/apache/pinot/pull/14723 fixed a concurrency bug in the Pinot JDBC client's date time utils where a single SDF instance could be shared across threads even though it isn't thread safe. - However, that patch switched to the newer `DateTimeFormatter` which isn't backward compatible with the older `SimpleDateFormat`. https://github.com/apache/pinot/pull/14739 attempted to fix some of the incompatibilities but there will always be some edge cases that aren't covered and it is critical to maintain backward compatibility for clients. - This patch reverts back to using `SimpleDateFormat` but with `ThreadLocal` instead to achieve thread safety. This is more expensive since each thread would need to allocate an instance of SDF but is necessary for thread safety and correctness (as can be demonstrated from the tests added earlier). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
