gortiz commented on code in PR #14345:
URL: https://github.com/apache/pinot/pull/14345#discussion_r1908494998
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/nativefst/ImmutableFSTDeserializedTest.java:
##########
@@ -41,6 +44,14 @@ public void setUp()
}
}
+ @AfterClass
+ public void tearDown()
+ throws IOException {
+ if (_fst instanceof ImmutableFST) {
+ ((ImmutableFST) _fst)._mutableBytesStore.close();
Review Comment:
~Don't you think FST should implement closeable?~
I'm reading the code and I don't think that is the case. Instead the caller
should own the PinotDataBufferMemoryManager instance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
