Jackie-Jiang commented on code in PR #14536:
URL: https://github.com/apache/pinot/pull/14536#discussion_r1909859120
##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -259,7 +259,9 @@ protected void startServers(int numServers)
throws Exception {
FileUtils.deleteQuietly(new File(TEMP_SERVER_DIR));
for (int i = 0; i < numServers; i++) {
- _serverStarters.add(startOneServer(i));
+ BaseServerStarter serverStarter = startOneServer(i);
+ _serverStarters.add(serverStarter);
+ _helixAdmin.enableInstance(getHelixClusterName(),
serverStarter.getInstanceId(), true);
Review Comment:
I don't think explicitly enabling is required. In `InstanceConfig`:
```
public boolean getInstanceEnabled() {
return
_record.getBooleanField(InstanceConfigProperty.HELIX_ENABLED.name(),
HELIX_ENABLED_DEFAULT_VALUE);
}
```
`HELIX_ENABLED_DEFAULT_VALUE` is `true` here.
Can you double check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
