bziobrowski commented on code in PR #14833:
URL: https://github.com/apache/pinot/pull/14833#discussion_r1925114511
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -208,24 +184,6 @@ public static String trim(String end, String characters,
String value) {
}
}
- /**
- * @param input
- * @return trim spaces from left side of the string
- */
- @ScalarFunction
- public static String ltrim(String input) {
Review Comment:
The new implementation shares the matcher, instead of allocating a new one
per call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
